A little upgrade problem

Hi,

I upgraded to 2.3.4, but the there is problem with the first page.
URL http://www.zeynepadali.com/agb/index.php
As you can see, visitor's e-mail doesn't show up correct. I modified something when i first installed AGB, but after upgrade, i cannot find the problem. Can you help me?

Because you have put

$row[email2] where it should say $EMAIL

This is the second occurance in the entry.php file not the first.

Thanx Carbonize, it says $EMAIL in the second occurance, as you say. Below is the code...

<tr bgcolor="$bgcolor">
<td width="32%" valign="top">
<table border="0" cellspacing="0" cellpadding="2">
<tr>
<td class="font2" valign="top" width="8%"><b>$id)</b></td>
<td width="92%"> <img src="$GB_PG[base_url]/img/ip.gif" width="14" height="14" alt="$LANG[AltIP]">  <img src="$GB_PG[base_url]/img/browser.gif" width="16" height="16" alt="$row[browser]"> 
$URL
$ICQ
$AIM
</td>
</tr>
<tr>
<td colspan="2" class="font1"><b>$row[name]</b> $GENDER</td>
</tr>
<tr>
<td colspan="2" class="font1">$row[email]</td>
</tr>

</table>
</td>
<td width="68%" class="font1" valign="top">
<div align="left" class="font3"><img src="$GB_PG[base_url]/img/post.gif" width="9" height="9">$DATE $HOST
<a href="$GB_COMMENT"><img src="$GB_PG[base_url]/img/edit.gif" width="18" height="13" border="0" alt="$LANG[AltCom]"></a>
$EMAIL
</div>
<hr size="1"><div align="left">
$USER_PIC $MESSAGE
</div>
$COMMENT
</td>
</tr>

Problem must lie in gb.class.php then

ok, but i am not good enough to make "dangerous" changes with the code. last time i did that was a disaster. i see three functions in the code, the problem may be in show entires function i think. code is long, looks dangerous to me

i paste it below...
function get_entries($entry,$last_entry) {
global $GB_UPLOAD, $GB_PG;
$entry = intval($entry);
$last_entry = intval($last_entry);
$img = new gb_image();
$img->set_border_size($this->db->VARS["img_width"], $this->db->VARS["img_height"]);
$LANG = &$this->db->LANG;
$id = $this->total-$entry;
$HOST = '';
$COMMENT = '';
$GB_ENTRIES = '';
$i=0;
$template['entry'] = $this->template->get_template($this->db->GB_TPL['entry']);
$template['com'] = $this->template->get_template($this->db->GB_TPL['com']);
$template['url'] = $this->template->get_template($this->db->GB_TPL['url']);
$template['icq'] = $this->template->get_template($this->db->GB_TPL['icq']);
$template['aim'] = $this->template->get_template($this->db->GB_TPL['aim']);
$template['email'] = $this->template->get_template($this->db->GB_TPL['email']);
$template['image'] = $this->template->get_template($this->db->GB_TPL['image']);
$result = $this->db->query("select x.*, y.p_filename, y.width, y.height, z.comments from ".$this->db->table['data']." x left join ".$this->db->table['pics']." y on (x.id=y.msg_id and y.book_id=2) left join ".$this->db->table['com']." z on (x.id=z.id) group by x.id order by x.id desc limit $entry, $last_entry");
while ($row = $this->db->fetch_array($result)) {
$row['email2'] = "";
$DATE = $this->db->DateFormat($row['date']);
$MESSAGE = nl2br($row['comment']);
if ($row['p_filename'] && ereg("^img-",$row['p_filename'])) {
if (file_exists("$this->path/$GB_UPLOAD/t_$row[p_filename]")) {
$row['p_filename'] = "t_$row[p_filename]";
}
$new_img_size = $img->get_img_size_format($row['width'], $row['height']);
eval("\$USER_PIC = \"".$template['image']."\";");
} else {
$USER_PIC = '';
}
if ($this->db->VARS["smilies"] == 1) {
$MESSAGE = $this->db->emotion($MESSAGE);
}
if (!$row['location']) {
$row['location'] = "-";
}
$bgcolor = ($i % 2) ? $this->db->VARS["tb_color_2"] : $this->db->VARS["tb_color_1"];
$i++;
if ($row['url']) {
eval("\$URL = \"".$template['url']."\";");
} else {
$URL = '';
}
if ($row['icq'] && $this->db->VARS["allow_icq"]==1) {
eval("\$ICQ = \"".$template['icq']."\";");
} else {
$ICQ = '';
}
if ($row['aim'] && $this->db->VARS["allow_aim"]==1) {
eval("\$AIM = \"".$template['aim']."\";");
} else {
$AIM = '';
}
if ($row['email']) {
/* E-mail Hack */
$row['email2'] = str_replace("@", "(at)", $row['email']);
$row['email2'] = str_replace(".", "(dot)", $row['email2']);
$row['email'] = "javascript:getEmail('".$this->db->encryptEmail("mailto:".$row['email'])."')";
eval("\$EMAIL = \"".$template['email']."\";");
} else {
$EMAIL = '';
}
if ($this->db->VARS["allow_gender"]==1) {
$GENDER = ($row['gender']=="f") ? " <img src=\"$GB_PG[base_url]/img/female.gif\" width=\"12\" height=\"12\">" : " <img src=\"$GB_PG[base_url]/img/male.gif\" width=\"12\" height=\"12\">";
} else {
$GENDER = '';
}
if ($this->db->VARS["show_ip"] == 1) {
$hostname = ( eregi("^[-a-z_]+", $row['host']) ) ? "Host" : "IP";
$HOST = "$hostname: $row[host]\n";
}
if ($row['comments']) {
$this->db->query("select * from ".$this->db->table['com']." where id='$row[id]' order by com_id asc");
while ($com = $this->db->fetch_array($this->db->result)) {
$com['comments'] = nl2br($com['comments']);
eval("\$COMMENT .= \"".$template['com']."\";");
}
}
$GB_COMMENT = (IS_MODULE && eregi("\?",$GB_PG["comment"])) ? "$GB_PG[comment]&gb_id=$row[id]" : "$GB_PG[comment]?gb_id=$row[id]";
eval("\$GB_ENTRIES .= \"".$template['entry']."\";");
$COMMENT = "";
$id--;
}
$TPL['GB_ENTRIES'] = $GB_ENTRIES;
return $TPL;
}

in entry.php $row[email] needs to be $row[email2]

now that's more funny,
an e-mail adress that should appear as "admin@zeynepadali.com" appears like this: "admin(at)zeynepadali(dot)com"

any solution for that??

thanks for your patiance...

Thats a security feature that aims at preventing spam bots from harvesting your guests email addresses.

i didnt know that, good idea.

thank you again carbonize, everything seems fine now after the upgrade.