Joined: 12/06/2003 19:26:08
Messages: 4292
Location: Bristol, UK
Offline
Just a couple of issues with your website.
1 - The contact link is hidden behind the visitors link box.
2 - The visitors link box is being reversed in IE.
3 - Move the contact form message to the actual contact form as it detracts from the main business
As to the contact script
1 - Make the url used in the meta refresh a variable at the top of the script for easier editing by users.
2 - Use htmlspecialchar on the data you are receiving before sending it in the email.
3 - You use divs with CSS throughout but then use a font tag at the end for some bizarre reason.
4 - In the $theResults variable you have a style block after the closing </html>. This is the wrong place for a style block anyway but the only thing it references is iframes and there are none in the script to be styled.
5 - Instead of using the HEREDOC to store the HTML in the $theResults variable you can just echo it like
6 - Need to check you actually have some data to send. At present I can turn off JavaScript and send you a blank email
7 - instead of
$name = $_POST['name'];
try
$name = (!empty($_POST['name'])) ? htmlspecialchars($_POST['name']) : '';
This should deal with point 2 and help with the checking for point 6
Carbonize I am not the maker of the Advanced Guestbook